Implement getstepsize() for NoAdaptation samplers #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2405 +/- ##
==========================================
+ Coverage 86.41% 86.62% +0.20%
==========================================
Files 22 22
Lines 1575 1577 +2
==========================================
+ Hits 1361 1366 +5
+ Misses 214 211 -3 ☔ View full report in Codecov by Sentry. |
penelopeysm
force-pushed
the
py/getstepsize-noadaptation
branch
2 times, most recently
from
c86a34e to
ce5f3a5
Compare
Pull Request Test Coverage Report for Build 12355640806Details
💛 - Coveralls |
penelopeysm
force-pushed
the
py/getstepsize-noadaptation
branch
2 times, most recently
from
e39208f to
fdcd4d5
Compare
penelopeysm
force-pushed
the
py/getstepsize-noadaptation
branch
from
fdcd4d5 to
4a78972
Compare
|
make sense, but coverage is saying that the added function is not hit, is it making a mistake? Also a bunch of test errors -- I thought they are not related, but might be? |
|
No idea why the coverage isn't right. I tried to rerun and it's no different... Yeah the errors are Mooncake related so separate from this PR. |
yebai
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2400